Skip to content

chore!: remove deprecated colors from gamut-styles#3349

Open
LinKCoding wants to merge 5 commits into
mainfrom
kl-gmt-1628-dep-colors
Open

chore!: remove deprecated colors from gamut-styles#3349
LinKCoding wants to merge 5 commits into
mainfrom
kl-gmt-1628-dep-colors

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented May 14, 2026 •
edited by atlassian Bot
Loading

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1628
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Check that tests pass
  2. Click around SB, nothing should be affected
  3. ...
  4. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding LinKCoding force-pushed the kl-gmt-1628-dep-colors branch from 8113550 to 3028a5f Compare May 14, 2026 20:35
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 14, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0853ae0

☁️ Nx Cloud last updated this comment at 2026-05-29 20:26:25 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.90%. Comparing base (0ef1fe2) to head (0853ae0).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
- Coverage   90.40%   89.90%   -0.50%     
==========================================
  Files         405      276     -129     
  Lines        6646     5723     -923     
  Branches     2149     1891     -258     
==========================================
- Hits         6008     5145     -863     
+ Misses        630      570      -60     
  Partials        8        8
Flag Coverage Δ
main ?
pull-request 89.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding LinKCoding changed the title Kl gmt 1628 dep colors chore!: remove deprecated colors from gamut-styles May 15, 2026
LinKCoding
LinKCoding commented May 18, 2026
View reviewed changes
Comment thread packages/gamut-styles/README.md Outdated

This folder houses all shared SCSS style variables.
It also contains a JavaScript file with color variables.
TypeScript color tokens and palettes live in `variables/colors.ts` and are exposed on themes as `theme.colors` (see `src/themes/`). Legacy `editorColors`, `platformColors`, `swatches`, and the flat deprecated `colors` map were removed from this package—use `corePalette` / `platformPalette` and theme color modes instead.
Copy link
Copy Markdown
Contributor Author

@LinKCoding LinKCoding May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI added this, I have no strong feeling about it, but think it's good to mention the removal of colors somewhere.

Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a little weird to me that we're only mentioning colors when there are a bunch of vars in variables. also theres a bunch of other tokens/helpers within the src folder besides variables

LinKCoding
LinKCoding commented May 18, 2026
View reviewed changes
Comment thread packages/gamut-styles/utils/variables/index.js
@@ -1,8 +0,0 @@
if (process.env.NODE_ENV === 'development') {
Copy link
Copy Markdown
Contributor Author

@LinKCoding LinKCoding May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no consuming repo pulling in this variable.

@LinKCoding LinKCoding marked this pull request as ready for review May 18, 2026 15:43
@LinKCoding LinKCoding requested a review from a team as a code owner May 18, 2026 15:43
@LinKCoding LinKCoding requested review from aresnik11 and dreamwasp May 19, 2026 17:35
aresnik11
aresnik11 approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Small comment on the README but otherwise LGTM

Comment thread packages/gamut-styles/README.md Outdated
@@ -5,7 +5,7 @@ Base SCSS for Codecademy
## Variables/

This folder houses all shared SCSS style variables.
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of these are SCSS variables, can we remove

Comment thread packages/gamut-styles/README.md Outdated

This folder houses all shared SCSS style variables.
It also contains a JavaScript file with color variables.
TypeScript color tokens and palettes live in `variables/colors.ts` and are exposed on themes as `theme.colors` (see `src/themes/`). Legacy `editorColors`, `platformColors`, `swatches`, and the flat deprecated `colors` map were removed from this package—use `corePalette` / `platformPalette` and theme color modes instead.
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a little weird to me that we're only mentioning colors when there are a bunch of vars in variables. also theres a bunch of other tokens/helpers within the src folder besides variables

@aresnik11 aresnik11 mentioned this pull request May 28, 2026
Open
7 tasks
@LinKCoding LinKCoding force-pushed the kl-gmt-1628-dep-colors branch from 20c42b9 to 0853ae0 Compare May 29, 2026 20:23
@codecademydev
Copy link
Copy Markdown
Collaborator

codecademydev commented May 29, 2026

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 68.7.2-alpha.3fff46.0 npm diff
@codecademy/gamut-icons 9.57.6-alpha.3fff46.0 npm diff
@codecademy/gamut-illustrations 0.58.12-alpha.3fff46.0 npm diff
@codecademy/gamut-kit 0.6.603-alpha.3fff46.0 npm diff
@codecademy/gamut-patterns 0.10.31-alpha.3fff46.0 npm diff
@codecademy/gamut-styles 18.0.1-alpha.3fff46.0 npm diff
@codecademy/gamut-tests 6.0.2-alpha.3fff46.0 npm diff
@codecademy/variance 0.26.2-alpha.3fff46.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.3fff46.0 npm diff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

🚀 Styleguide deploy preview ready!

Preview URL: https://6a19f7263368f2bbc1315f23--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/6a19f7263368f2bbc1315f23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@dreamwasp dreamwasp Awaiting requested review from dreamwasp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LinKCoding @codecademydev @aresnik11